2008-03-10
| 09:25 | Chouser | I looked briefly at getting the Arity exception to include the name of the function being called. Looks tricky. |
| 09:26 | Chouser | It looks like functions don't know their own names? So I suppose that would have to change -- the name as given by defn or the option name param to fn would have to be copied into the function object itself? |
| 09:27 | Chouser | ...which sounds a bit messy. |
| 09:31 | rhickey | would really have to be passed to the fn's base class - most are derived from AFn and it is AFn that actually throws the exception (i.e. the AFn version of every overload of invoke() throws so that every fn doesn't have to) |
| 09:31 | Chouser | right. Is that too ugly a solution to consider? |
| 09:32 | rhickey | not all fns are named, fns with same name can exist in multiple namespaces |
| 09:32 | rhickey | not impossible |
| 09:33 | Chouser | yeah, it wouldn't be any kind of "canonical" name. Just a potentially helpful string for use in debugging. |
| 09:33 | Chouser | maybe nobody else has as much trouble debugging such exceptions as I do. :-) |
| 09:35 | rhickey | I'll think about it |
| 09:36 | Chouser | If you'd be willing to accept such a solution but don't find it urgent, I could try writing a patch. |
| 09:37 | rhickey | don't even think about a patch - this needs: |
| 09:37 | rhickey | a change to core base classes AFn and RestFn |
| 09:37 | rhickey | code gen support |
| 09:39 | Chouser | hm. ok. I guess I'll go back to trying to get jswat to work for me instead. |
| 09:39 | rhickey | if you get this error, a good hint will be just down the stack trace - the line where the call was made |
| 09:40 | Chouser | yeah, I'm looking at the line, and still don't know what I'm doing wrong. |
| 09:40 | Chouser | cons with 2 args, assoc with 3, another assoc with 3. *shrug* |
| 09:41 | Chouser | Is the line named in the stack trace where the ( was found, or the )? |
| 09:42 | rhickey | ( |
| 09:42 | Chouser | If it's the (, then the only thing on that line is (cons obj oldobjs) ...in which case I must be missing something. |
| 09:43 | rhickey | are you in a macro? |
| 09:43 | Chouser | Ah! good question ... sync and defn |
| 09:44 | rhickey | line numbers and macros are not behaving well at present |
| 09:44 | rhickey | which is a problem given fn/let/loop are now macros |
| 09:44 | Chouser | :-) |
| 09:45 | Chouser | Hm, I get some kind of internal name for the function in the stack trace. I wonder if I can use that... |
| 09:45 | Chouser | at clojure.fn__1198$fn__1199.invoke |
| 09:46 | rhickey | I was just looking at why those internal names aren't better - they used to be |
| 09:46 | rhickey | for other than truly anonymous fns, after ns. should be the function name |
| 09:47 | rhickey | in your case, given ns is clojure, the line # probably corresponds to boot.clj |
| 09:48 | Chouser | at clojure.fn__1198$fn__1199.invoke(scratch09.clj:96) |
| 09:49 | Chouser | that seems to be about right. (prn)'s before that line print, but those after it do not. |
| 09:49 | Chouser | oh! |
| 09:49 | Chouser | ok, now I feel silly |
| 09:50 | Chouser | "set" used to be for mutating refs, right? |
| 09:50 | rhickey | right, now use ref-set |
| 09:50 | Chouser | and there's my problem. :-) |
| 09:51 | rhickey | sorry about that, only doc is in SVN commit comments right now |
| 09:51 | Chouser | so it was the line number of the ) |
| 09:51 | Chouser | no need to apologize. |
| 09:51 | Chouser | I wouldn't have read the docs yet anyway. This was old code I had just pasted in. |
| 09:52 | Chouser | in fact (doc set) was my first break. :-) |
| 10:12 | rhickey | ok - fixed fn name propagation, so e.g. instead of: clojure.fn__1198 you'll get: cljfn.clojure.set__546 |
| 10:12 | rhickey | should greatly aid debugging |
| 10:18 | Chouser | ah, nice! thanks. |
| 10:19 | Chouser | actually, I get: at cljfn.cljfn.clojure.db_set__1177$fn__1178.invoke(scratch09.clj:95) |
| 10:20 | rhickey | db-set? |
| 10:20 | Chouser | db-set is the name of my function that includes line 95 |
| 10:21 | rhickey | the double cljfn is wrong - will fix |
| 10:21 | rhickey | did you define db-set in the clojure namespace? |
| 10:21 | Chouser | (defn db-set [...] (sync nil ... (set db ...))) |
| 10:22 | Chouser | hm. apparently. I just define it in scratch09.clj, and run it like this: java -cp ~/build/clojure/clojure.jar clojure.lang.Repl scratch09.clj |
| 10:23 | rhickey | with no in-ns in the file? |
| 10:27 | rhickey | double cljfn prefix fixed, prefix ns is now clojure.fns. |
| 10:30 | Chouser | nope, no in-ns in the file. Should I do something like: (in-ns 'user) (clojure/refer 'clojure) at the top? |
| 10:31 | rhickey | you should put it in some ns unless it is a real one-off |
| 10:31 | rhickey | I just wanted to understand the name you posted |
| 10:32 | Chouser | right. ok, now I'm getting: at clojure.fns.user.db_set__1177$fn__1178.invoke(scratch09.clj:98) |
| 10:32 | rhickey | good |
| 10:33 | Chouser | I guess that helps confirm that problem is indeed at line 98 inside my db-set function. |
| 10:33 | rhickey | is it/ |
| 10:33 | rhickey | ? |
| 10:33 | Chouser | yes |
| 10:33 | rhickey | all is well then |
| 10:33 | Chouser | but the problem is calling set with 2 params when it wants just 1. |
| 10:34 | Chouser | line 98 has a call to cons and the close-paren for set |
| 10:35 | rhickey | that's as good as it gets for now |
| 10:35 | Chouser | ok. thanks! |
| 15:19 | Chouser | Cool, I get to use set/intersection. |
| 15:19 | rhickey | does it work? |
| 15:22 | Chouser | of course |
| 16:14 | middayc | hi folks |
| 17:32 | jgracin | hi middayc! |